New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced direct class in instance creation #642

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@dmishh

dmishh commented Apr 4, 2013

return new EntityManager() -> return new static() on line 945
made code more reusable

replaced direct class in instance creation
return new EntityManager() -> return new static() on line 945
made code more reusable
@doctrinebot

This comment has been minimized.

doctrinebot commented Apr 4, 2013

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2389

@Ocramius

This comment has been minimized.

Member

Ocramius commented Apr 4, 2013

@dmishh the EntityManager is not meant to be extended. Use the Doctrine\Common\Persistence\ObjectManager interface and composition instead.

@Ocramius Ocramius closed this Apr 4, 2013

@DavertMik

This comment has been minimized.

DavertMik commented Apr 4, 2013

why it's not final then?

@Ocramius

This comment has been minimized.

Member

Ocramius commented Apr 4, 2013

@DavertMik can't change it now because of BC compatibility. I agree it should be (especially to avoid this kind of PR that always pops up)

@guilhermeblanco

This comment has been minimized.

Member

guilhermeblanco commented Apr 5, 2013

@DavertMik It can't be final because we require to Mock it for testing purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment