[wip] Pr mapping import #659

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@bronze1man
Contributor

bronze1man commented May 7, 2013

The bug:

1.use symfony2 doctrine:mapping:import from msyql database to annotation
2.use symfony2 doctrine:schema:update will see a lot of sql update about just import database schema.
3.this PR fix eliminate some of those sql update...

fix 8 bug:

  • column default
  • column unsigned
  • column type char
  • table without auto_increment
  • column comment
  • column type decimal
  • table with simple index
  • table with unique index

wip -> follow rule of contribute to doctrine

  • add patch on master
  • add test
@bronze1man

This comment has been minimized.

Show comment Hide comment
@bronze1man

bronze1man May 7, 2013

Contributor

two more bug forget to mention

  • table with simple index
  • table with unique index
Contributor

bronze1man commented May 7, 2013

two more bug forget to mention

  • table with simple index
  • table with unique index
@Ocramius

This comment has been minimized.

Show comment Hide comment
@Ocramius

Ocramius May 7, 2013

Member

@bronze1man bug fixes need tests that demonstrate the failures!

Member

Ocramius commented May 7, 2013

@bronze1man bug fixes need tests that demonstrate the failures!

@bronze1man

This comment has been minimized.

Show comment Hide comment
@bronze1man

bronze1man May 8, 2013

Contributor

1.use symfony2 doctrine:mapping:import from msyql database to annotation
2.use symfony2 doctrine:schema:update will see a lot of sql update about just import database schema.
3.this PR fix eliminate some of those sql update...

Contributor

bronze1man commented May 8, 2013

1.use symfony2 doctrine:mapping:import from msyql database to annotation
2.use symfony2 doctrine:schema:update will see a lot of sql update about just import database schema.
3.this PR fix eliminate some of those sql update...

@bronze1man bronze1man deleted the bronze1man:PR-mapping-import branch Jun 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment