Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INVALID] [DDC-2452] DQL arbitrary joins between JTI entities produces invalid SQL #668

Closed

Conversation

Ocramius
Copy link
Member

DDC-2452 - DQL joins between JTI entities produce invalid SQL when additional conditions are inserted via WITH clause

Still working on a fix

DQL joins between JTI entities produce invalid SQL when additional conditions are inserted via WITH clause
@ghost ghost assigned Ocramius May 16, 2013
@guilhermeblanco
Copy link
Member

@Ocramius this seems to be an issue that precedence of joins would fix it

@Ocramius
Copy link
Member Author

@guilhermeblanco you mean #656? No, that doesn't fix this one (already tried pulling it locally)

@guilhermeblanco
Copy link
Member

@guilhermeblanco
Copy link
Member

@Ocramius
Copy link
Member Author

@guilhermeblanco indeed the fix seems to be invalid - this fixes the tests in SQLite platform, but breaks on MySQL platform...

@Ocramius
Copy link
Member Author

Closing since the fix is invalid and I cannot come up with something better right now

@Ocramius Ocramius closed this Jun 24, 2013
@mattjanssen
Copy link

Does #708 take care of this exact issue?

@Ocramius
Copy link
Member Author

@mattjanssen not really, the problem here is that the ON keyword was produced twice in SQLite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants