Implement QuoteStrategy on SqlWalker walkRangeVariableDeclaration #688

Merged
merged 4 commits into from Jun 12, 2013

Projects

None yet

3 participants

@FabioBatSilva
Member

Could you add a test please ?
Something like this

John Brown Adding simple test to ensure quoting of table names still functions. …
…Note: the funtionality of this change won't be noticiable unless a custom quote strategy is implemented
9bea612
@johnbrown

I added a simple test. However, the functionality should not change unless a custom QuoteStrategy is implemented.

@FabioBatSilva
Member

You are right about the test.

Anyway, if you are interested,
there is two other points where you can replace the old quote API : L878 and L933

@guilhermeblanco guilhermeblanco merged commit 6ef4856 into doctrine:master Jun 12, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment