Skip to content

commented a change that was ahead of stable; added calls to getters #699

Closed
wants to merge 1 commit into from

4 participants

@rbroen
rbroen commented Jun 15, 2013

CreateHelperSet appears to be a method in 2.4, which is not stable yet and does not correspond with this 2.3 tutorial.
list_bugs.php was trying to get protected vars.

@rbroen rbroen commented a change that was ahead of stable; added calls to getters
CreateHelperSet appears to be a method in 2.4, which is not stable yet and does not correspond with this 2.3 tutorial.
list_bugs.php was trying to get protected vars.
bb43e8c
@stof
Doctrine member
stof commented Jun 16, 2013

this doc is in the master branch, not in the 2.3 branch. So it is perfectly valid to use a 2.4 method when documenting the 2.4 codebase

@Ocramius
Doctrine member

@stof said everything :)

@Ocramius Ocramius closed this Jun 16, 2013
@rbroen
rbroen commented Jun 16, 2013

The page on "http://docs.doctrine-project.org/en/latest/tutorials/getting-started.html" contains a not that states that "This tutorial assumes you work with Doctrine 2.3 and above. Some of the code will not work with lower versions.". The problem is that some of the first lines of codes in the getting-started will NOT work with 2.3, but only from 2.4+. This is a problem for people starting with the latest stable version (being: 2.3).

@Ocramius
Doctrine member
@rbroen
rbroen commented Jun 16, 2013

Just trying to help out. Something is not matching. Sorry I can't figure out how to help.

@gws
gws commented Jun 16, 2013

@rbroen What about changing that note (in master) to

This tutorial assumes you work with Doctrine 2.4 and above

And remove your other changes? Then the note would be accurate and the docs become simpler to follow for people who are getting started (after all, that's the tutorial name) with Doctrine both now and once 2.4 is released.

I think it's a separate issue that the previous branch docs on Doctrine project homepage all redirect to "latest", but any 2.3-specific documentation should go in the 2.3 branch, in my opinion.

@rbroen rbroen deleted the unknown repository branch Jun 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.