Access properties via static:: instead of self::. #719

Merged
merged 1 commit into from Jul 18, 2013

Projects

None yet

4 participants

@tristanlins
Contributor

The properties of EntityGenerator are now protected instead of private.
But this does not make sense until they are accessed with static::.
Otherwise the templates cannot be overwritten within a sub class.

@tristanlins tristanlins Access properties via static:: instead of self::.
The properties of EntityGenerator are now protected instead of private.
But this does not make sense until they are accessed with static::.
Otherwise the templates cannot be overwritten within a sub class.
6417746
@doctrinebot

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2546

We use Jira to track the state of pull requests and the versions they got
included in.

@Padam87
Contributor
Padam87 commented Jul 5, 2013

👍

@guilhermeblanco guilhermeblanco merged commit fbbb161 into doctrine:master Jul 18, 2013

1 check passed

default The Travis CI build passed
Details
@tristanlins tristanlins deleted the tristanlins:fix/entity-generator-extensibility branch Jul 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment