Minor updates while reading the basic-mapping page #786

Merged
merged 2 commits into from Sep 13, 2013

3 participants

@weaverryan

Hi guys!

This is just from a quick read-through of the basic-mapping page. Most changes are pretty minor :).

The only arguable changes involve a few spots where I either removed something I thought was too technical and not valuable (e.g. talking about the metadata mapping pattern).

Thanks!

@weaverryan weaverryan Minor updates while reading the basic-mapping page
The only arguable changes involve a few spots where I either removed something I thought was too technical and not valuable (e.g. talking about the metadata mapping pattern).
36d7d60
@doctrinebot

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2676

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius Ocramius commented on an outdated diff Sep 12, 2013
docs/en/reference/basic-mapping.rst
@@ -4,12 +4,12 @@ Basic Mapping
This guide explains the basic mapping of entities and properties.
After working through this guide you should know:
-- How to create PHP classes that can be saved in the database with Doctrine
+- How to create PHP classes that can be saved to the database with Doctrine;
@Ocramius
Doctrine member

Probably PHP objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@Ocramius Ocramius commented on an outdated diff Sep 12, 2013
docs/en/reference/basic-mapping.rst
@@ -23,11 +23,11 @@ Doctrine.
Creating Classes for the Database
---------------------------------
-Every PHP Class that you want to save in the database using Doctrine
-need to be marked as "Entity". The term "Entity" describes objects
-that have identity over many independent requests. This identity is
+Every PHP class that you want to save in the database using Doctrine
@Ocramius
Doctrine member

again, object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@Ocramius Ocramius and 1 other commented on an outdated diff Sep 12, 2013
docs/en/reference/basic-mapping.rst
-Doctrine provides several different ways for specifying object-relational
+Doctrine provides several different ways to specifying object-relational
@Ocramius
Doctrine member

of? :)

Actually, "to" sounds a little bit better here, but I'm glad you made this comment because with "to", "specifying" must be "specify". I've made that tweak :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@weaverryan

@Ocramius thanks! Tweaks made!

@Ocramius Ocramius merged commit c72698a into doctrine:master Sep 13, 2013
@Ocramius
Doctrine member

@weaverryan thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment