Implemented "contains" operator for Criteria expressions #791

Merged
merged 1 commit into from Oct 11, 2013

4 participants

@mnapoli

Criteria expressions support the contains operator, and it is implemented for the ArrayCollection. However, it wasn't implemented in the QueryExpressionVisitor, the ORM implementation.

This is the implementation and the test.

The only thing I'm wondering: is the % wildcard valid for all supported RDBMS for the LIKE operator? After a quick search, it seems like so, but you guys probably know for sure.

FYI it seems that someone created an issue for this, but it was closed: DDC-2394

@doctrinebot

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2682

We use Jira to track the state of pull requests and the versions they got
included in.

@mnapoli

ping

This is a fairly simple fix, and annoying bug :)

@guilhermeblanco guilhermeblanco merged commit be81b46 into doctrine:master Oct 11, 2013

1 check passed

Details default The Travis CI build passed
@Thinkscape

Thank you for that. I'm now patching all 2.4 instances with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment