Options not respected for ID Fields in XML Mapping Driver #816

Merged
merged 2 commits into from Jan 2, 2014

Projects

None yet

6 participants

@leggiero
leggiero commented Oct 9, 2013

Same bug of the YAML driver, see: http://www.doctrine-project.org/jira/browse/DDC-2661

@doctrinebot
Collaborator

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2732

We use Jira to track the state of pull requests and the versions they got
included in.

@FabioBatSilva
Member

@Dudytz can you add a test case please ?

@leggiero
leggiero commented Oct 9, 2013

@FabioBatSilva I don't have a working dev environment for doctrine to create the test cases. This is the same bug that has been resolved only in the YAML driver. PS: this bug exists in all the branches (2.0, 2.1, 2.2, 2.3, 2.4 and master) in the YAML driver and XML driver.

@giosh94mhz

Please, backport this fix also on 2.3.*

@Ocramius Ocramius commented on the diff Oct 17, 2013
doctrine-mapping.xsd
@@ -350,6 +350,7 @@
<xs:element name="generator" type="orm:generator" minOccurs="0" />
<xs:element name="sequence-generator" type="orm:sequence-generator" minOccurs="0" maxOccurs="1" />
<xs:element name="custom-id-generator" type="orm:custom-id-generator" minOccurs="0" maxOccurs="1" />
+ <xs:element name="options" type="orm:options" minOccurs="0" />
@Ocramius
Ocramius Oct 17, 2013 Doctrine member

maxOccurs="1"?

@giosh94mhz
giosh94mhz Oct 18, 2013

@Ocramius I agree with you, since there should be one "options" node with multiple "option" children.

@beberlei beberlei merged commit 333177d into doctrine:master Jan 2, 2014

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment