Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

faild test with multiple HINT_CUSTOM_TREE_WALKERS #934

Merged
merged 6 commits into from Feb 8, 2014

Conversation

Projects
None yet
5 participants
Contributor

shustrik commented Feb 5, 2014

This PR contains failed test when we have more than 1 HINT_CUSTOM_TREE_WALKERS ,
because walkSelectStatement in TreeWalkerChain saves only last hint _queryComponents result. Could you, please, help to resolve this issue or fix it?

@shustrik shustrik faild test with multiple HINT_CUSTOM_TREE_WALKERS
failed test when we have more than 1 walker HINT_CUSTOM_TREE_WALKERS ,
because walkSelectStatement in TreeWalkerChain saves the last hint _queryComponents result.
7107a85

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2956

We use Jira to track the state of pull requests and the versions they got
included in.

Contributor

shustrik commented Feb 6, 2014

anybody?

Contributor

shustrik commented Feb 6, 2014

@Ocramius can you please check?

Contributor

shustrik commented Feb 6, 2014

yes

Contributor

shustrik commented Feb 6, 2014

@Ocramius as i see, issue created 2 years ago. Сan i ask, it will be fixed?

Contributor

shustrik commented Feb 8, 2014

ping @Ocramius @beberlei . Sorry, but it's important issue for me.

@beberlei beberlei added a commit that referenced this pull request Feb 8, 2014

@beberlei beberlei Merge pull request #934 from shustrik/master
faild test with multiple HINT_CUSTOM_TREE_WALKERS
0c2c500

@beberlei beberlei merged commit 0c2c500 into doctrine:master Feb 8, 2014

1 check passed

default The Travis CI build passed
Details
Contributor

naitsirch commented Jun 9, 2015

It's a pity that this is not available in version 2.4 :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment