Made the $event parameter of EventManager::getListeners() mandatory#57
Merged
derrabus merged 1 commit intodoctrine:2.0.xfrom Oct 10, 2022
Merged
Conversation
SenseException
approved these changes
Oct 10, 2022
malarzm
reviewed
Oct 10, 2022
| return $this->getAllListeners(); | ||
| } | ||
|
|
||
| return $this->listeners[$event]; |
Member
There was a problem hiding this comment.
Now I'm seeing this method clearly it occurred to me :D What about an event that has no listeners? Is calling hasListeners the way to go? Right now this will emit PHP's warning about undefined key, which will hopefully be transformed into an exception. Maybe ?? [] should be used instead?
Member
Author
There was a problem hiding this comment.
Returning an empty array sounds like the reasonable thing to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #50.