Allow editor-cmd to work with terminal-based editors #102

merged 1 commit into from Mar 3, 2015


None yet
2 participants

arnaud-lb commented Nov 26, 2012

This allows --editor-cmd=vim to work correctly in generate commands.

shell_exec captures the output, as a result a terminal-based editor cannot display anything on the terminal.

proc_open, when called with an empty $descriptorspec argument, lets the executed command inherit its file descriptors; as a result the editor can display itself in the terminal.

mikeSimonson added the 2.0 label Feb 14, 2015

@mikeSimonson mikeSimonson modified the milestone: 1.0 Feb 15, 2015

mikeSimonson merged commit 3298a2e into doctrine:master Mar 3, 2015

1 check passed

default The Travis build passed

arnaud-lb commented Mar 3, 2015

Awesome, thanks @mikeSimonson


mikeSimonson commented Mar 3, 2015

@arnaud-lb Thanks for your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment