package.php now succeeds in building the package (with deps installed via composer) #111

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

djfm commented Feb 26, 2013

It seems composer now installs stuff in directories different to those used before... I couldn't build the phar using the provided package.php file so I tweaked it and now it successfully builds!

Member

stof commented Feb 26, 2013

I would vote for simply removing this package.php file.

  • if we really want a phar, using Box is better than maintaining our own build script IMO
  • I don't see why we would build a phar with the migration library. This phar would embed all vendors, but you probably already have them in our project (to use DBAL). @beberlei @guilhermeblanco what do you think about this ?

djfm commented Feb 26, 2013

I'm using phar because the project I need migrations for does not use anything else from doctrine nor symfony, so it has none of the dependencies available...

+1 for merging this. I didn't see it so I will remove my PR. We want to use doctrine-migrations on a production server but without the rest of our application scope because that brings extra risks. Therefore we have decided to create a phar file.

I am diving into "Box" now.

Member

mikeSimonson commented Feb 22, 2015

close in favor of #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment