Remove unused AbstractMigration::$configuration and fix some CS #156

Merged
merged 1 commit into from Mar 5, 2015

Conversation

Projects
None yet
3 participants
Contributor

rybakit commented Jan 30, 2014

No description provided.

Contributor

rybakit commented Mar 4, 2015

Any comment on why this was closed?

Member

mikeSimonson commented Mar 5, 2015

@rybakit You are making too many different changes in your commit. It's very hard to read.
You are removing the Version use for instance too which apparently shouldn't.

Contributor

rybakit commented Mar 5, 2015

@mikeSimonson use Doctrine\DBAL\Migrations\Version is superfluous there, as both classes (AbstractMigration and Version) share the same namespace.

@stof stof reopened this Mar 5, 2015

Member

stof commented Mar 5, 2015

Reopening as this CS changes are indeed right.

@rybakit can you rebase your branch to fix conflicts ?

@mikeSimonson mikeSimonson added 1.0 and removed close ? labels Mar 5, 2015

@mikeSimonson mikeSimonson added this to the 1.0 milestone Mar 5, 2015

Contributor

rybakit commented Mar 5, 2015

@stof, @mikeSimonson Rebased.

Member

mikeSimonson commented Mar 5, 2015

@rybakit Thanks

mikeSimonson added a commit that referenced this pull request Mar 5, 2015

Merge pull request #156 from rybakit/abstract_migration
Remove unused AbstractMigration::$configuration and fix some CS

@mikeSimonson mikeSimonson merged commit b962049 into doctrine:master Mar 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rybakit rybakit deleted the rybakit:abstract_migration branch Mar 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment