Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow longer version names #53

Merged
merged 1 commit into from Nov 21, 2011

Conversation

Projects
None yet
2 participants
Contributor

mrtorrent commented Nov 16, 2011

The current migration table schema restricts the version column to 14 characters. It is useful to be able to give migration versions more descriptive names (as broached in #22) and, depending upon the scheme used, these may be longer than 14 characters, resulting in unexpected behaviour.

In databases that enforce the defined column length, longer version names will be silently truncated, which causes Configuration::hasVersionMigrated() to always return false for these versions. This means the system will erroneously always try to apply the migration. This is an issue in itself, and there should probably be a warning put in place and/or better some special handling of long version names, but a fast fix that will cover most use cases is to increase the length of the column storing the version names.

beberlei added a commit that referenced this pull request Nov 21, 2011

@beberlei beberlei merged commit 6d3f448 into doctrine:master Nov 21, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment