Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow "float" in formatBytes to work on 32-bit computers #803

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@remicollet
Copy link
Contributor

commented Mar 27, 2019

Alternative to pr #802 which could be better.

As float also allow int, I don't think this is a BC break, especially as the class is final

Copy link
Member

left a comment

It is possible to enable strict mode on a per-file basis. In strict mode, only a variable of exact type of the type declaration will be accepted, or a TypeError will be thrown. The only exception to this rule is that an integer may be given to a function expecting a float. Function calls from within internal functions will not be affected by the strict_types declaration.

TIL 💡

This means your change is backwards compatible 👍

@jwage jwage self-assigned this Mar 27, 2019
@jwage jwage added the Bug label Mar 27, 2019
@jwage jwage added this to the 2.0.1 milestone Mar 27, 2019
@jwage jwage changed the base branch from master to 2.0 Mar 27, 2019
@stof
stof approved these changes Mar 27, 2019
@jwage jwage changed the base branch from 2.0 to master Mar 27, 2019
@jwage

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Thanks @remicollet for this PR and everything else you do! I will merge this manually in to the 2.0 branch and release 2.0.1

@jwage jwage merged commit fa88033 into doctrine:master Mar 27, 2019
3 checks passed
3 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@remicollet remicollet deleted the remicollet:issue-32bits branch Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.