Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

doctrine:migrations:diff "--filter-expression" option ignored for $toSchema #85

Merged
merged 1 commit into from Sep 7, 2012

Conversation

Projects
None yet
3 participants
Contributor

iVariable commented Aug 16, 2012

DiffCommand "--filter-expression" option fix. Issue #84

Contributor

iVariable commented Aug 16, 2012

Okay

@megazoll megazoll commented on an outdated diff Aug 16, 2012

...DBAL/Migrations/Tools/Console/Command/DiffCommand.php
$tool = new SchemaTool($em);
$fromSchema = $conn->getSchemaManager()->createSchema();
$toSchema = $tool->getSchemaFromMetadata($metadata);
+
+ //Not using value from options, because filters can be set from config.yml
+ if ($filterExpr = $conn->getConfiguration()->getFilterSchemaAssetsExpression()) {
+ $tableNames = $toSchema->getTableNames();
+ foreach ($tableNames as $tableName) {
+ $tableName = substr($tableName, strpos($tableName,'.') + 1);
@megazoll

megazoll Aug 16, 2012

After comma should be space.

Contributor

iVariable commented Sep 7, 2012

Sorry for waiting. CS fixed, commits squashed.
@beberlei Is it ok now?

beberlei added a commit that referenced this pull request Sep 7, 2012

Merge pull request #85 from iVariable/master
doctrine:migrations:diff "--filter-expression" option ignored for $toSchema

@beberlei beberlei merged commit 17f4b56 into doctrine:master Sep 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment