Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax checker for contributors. #1097

Closed
wants to merge 2 commits into from
Closed

Add syntax checker for contributors. #1097

wants to merge 2 commits into from

Conversation

BernardoSilva
Copy link
Contributor

Did not run the tool against whole project to avoid creating conflict with all existing Pull requests.
But from now on all contributors can have their code automatically formatted according to PSR2 standard.

@alcaeus
Copy link
Member

alcaeus commented Oct 1, 2017

Using phpcs to enforce code quality is a good idea, but I don't like the idea of forcing a pre-commit hook on people on the client side. Besides that, doctrine has their own coding standard (see https://github.com/doctrine/coding-standard) which requires a space before a negation operator, so we should use that.

I believe we should use a more complete tool like scrutinizer to monitor these things and make pull requests fail if they introduce errors instead of relying client-side validation.

@alcaeus alcaeus closed this Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants