New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating references to "empty" identifiers #1503

Merged
merged 1 commit into from Oct 5, 2016

Conversation

Projects
None yet
1 participant
@alcaeus
Member

alcaeus commented Oct 5, 2016

Fixes #1394. This allows using falsey values as identifiers with references. All other checks to identifiers I could find explicitely check for null values, so it makes sense to do the same in createDbRef.

@alcaeus alcaeus added the bug label Oct 5, 2016

@alcaeus alcaeus added this to the 1.0.8 milestone Oct 5, 2016

@alcaeus alcaeus merged commit bfd101b into doctrine:1.0.x Oct 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alcaeus alcaeus deleted the alcaeus:fix-non-null-empty-ids branch Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment