Updated adapter to be consistent with other Doctrine adapters. #203

Closed
wants to merge 2 commits into
from

4 participants

@Gym
Gym commented Dec 6, 2011

No description provided.

@stof stof commented on the diff Dec 6, 2011
lib/Doctrine/ODM/MongoDB/Types/Type.php
@@ -104,33 +123,33 @@ public function closureToPHP()
*/
public static function registerType($name, $class)
{
- self::$typesMap[$name] = $class;
+ self::$_typesMap[$name] = $class;
@stof
Doctrine member
stof added a line comment Dec 6, 2011

you should not add _ for private properties. This was done in the old CS (and for instance new classes of the ORM don't use it either)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jwage
Doctrine member

Want to rebase this?

@jmikola
Doctrine member

Rebased in #546.

@jmikola jmikola closed this Apr 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment