Add some generic information #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
generics_part_1
branch
2 times, most recently
from
b8f91d2
to
873a72f
Compare
IonBazan
approved these changes
May 3, 2022
malarzm
requested changes
May 4, 2022
| * | ||
| * @return BaseCollection | ||
| * @psalm-return BaseCollection<array-key, TDocument> |
There was a problem hiding this comment.
This looks wrong: TDocument is taken from the parameter (which tells what class should be instantiated) and is definitely not what is later stored in the collection (we don't know what it'll be at this point). The only thing we can be kind-of-certain is that $collectionClass is a descendant of the Collection interface.
There was a problem hiding this comment.
yeah, totally right, I missed this, thanks!
malarzm
approved these changes
May 8, 2022
SenseException
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To reach level 6 of PHPStan the remaining check is about generics, there are ~110 errors. This PR fixes some the "easy" ones.
The rest I guess that will involve making some classes generic (
Builder,QueryandAggregateprobably) and that would mean more errors and changes.