Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[UoW] Use strict equality check for changeset comparisons #285

Merged
merged 1 commit into from Apr 4, 2012

Conversation

Projects
None yet
2 participants
Owner

jmikola commented Apr 3, 2012

This reverts commit 0e67e8f, but addresses tests added in 416a1a8.

Closes #209.

Build Status

@jmikola jmikola [UoW] Use strict equality check for changeset comparisons
This reverts commit 0e67e8f, but addresses tests added in 416a1a8.

Closes #209.
3483436
Owner

jmikola commented Apr 3, 2012

@jwage: Please review when you get a chance. For the moment, I'm going to point our application at this commit, since we don't have a fork and are in need of a fix for array_diff() surpassing PHP's execution time limit.

Tests pass, and the only negative side effect from this change might be extra fields being updated because they are strictly different (I'm not convinced that's undesirable, though). I reviewed the tests in 416a1a8, which complemented the code fix I reverted here, and they appear to be valid concerns. Using strict equality ensures that they still pass.

@jwage jwage added a commit that referenced this pull request Apr 4, 2012

@jwage jwage Merge pull request #285 from doctrine/changeset-equality
[UoW] Use strict equality check for changeset comparisons
dc1aa6e

@jwage jwage merged commit dc1aa6e into master Apr 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment