[Common 2.4+] added "documentNotFound" event to hook in the proxy initialization process #532

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@tecbot
Contributor
tecbot commented Mar 25, 2013

If the document not exists so a user can hook into and create a fallback objekt to prevent a exception.

@tecbot
Contributor
tecbot commented Mar 28, 2013

I have seen it was a bad diff. Now you can see the right changes. This stuff we have in production since 1 year and it works fine :).

@jmikola
Member
jmikola commented Mar 28, 2013

@ocramius: Thoughts on this? I believe there will be some conflict resolution necessary if #506 gets merged afterwards. Other than that, I think it's good -- perhaps ORM would be interested in this as well. /cc @jwage

@Ocramius
Member

@tecbot don't inject the event manager. Instead, you can add this event to the initializer in #506, which saves us a LOT of work in serialization/unserialization (and GC).

@jmikola I'd say #506 first, then adding this logic to the initializer of the proxy instead of the proxy itself.

@jwage
Member
jwage commented Apr 28, 2013

👍 for this feature. I can see myself using this to lazily clean up references.

@jmikola
Member
jmikola commented Apr 29, 2013

Just to confirm, this is blocked by #506, which in turn is being blocked by doctrine/common 2.4 (ETA is 2 weeks).

@jwage
Member
jwage commented Mar 28, 2015

Can we rebase the PR?

@malarzm malarzm added the feature label Oct 4, 2015
@alcaeus alcaeus self-assigned this Jan 6, 2016
@alcaeus
Member
alcaeus commented Jan 8, 2016

Superseded by #1336.

@alcaeus alcaeus closed this Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment