Throw exception for DateType conversion error and add tests #540

Merged
merged 2 commits into from May 30, 2013

Conversation

Projects
None yet
3 participants
Owner

jmikola commented Mar 28, 2013

@jwage: Please take a look at the first commit here, as it reverts behavior you originally added in b702787. I don't have a record of you following up on my comment there, but I think the behavior was incorrect.

I decided to follow up on this and add some unit tests while merging #533.

Contributor

tystr commented Mar 29, 2013

👍 Seems correct to throw an exception in this case

Owner

jmikola commented Apr 1, 2013

Note: this will need rebasing if #546 is merged first. Additionally, the test class will need to be fixed to respect the private Type constructor.

Owner

jwage commented Apr 28, 2013

👍

jmikola added some commits Mar 28, 2013

@jmikola jmikola Throw exception in DateType when conversion to MongoDate fails
This reverts a change introduced in b702787, which would store an ISO8601 date string on error.
c36c060
@jmikola jmikola Add unit tests for DateType 59b82e9

@jmikola jmikola added a commit that referenced this pull request May 30, 2013

@jmikola jmikola Merge pull request #540 from doctrine/datetype-tests
Throw exception for DateType conversion error and add tests
8c001be

@jmikola jmikola merged commit 8c001be into master May 30, 2013

jmikola deleted the datetype-tests branch May 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment