Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Refactor types to be consistent with other Doctrine adapters #546

Merged
merged 2 commits into from May 30, 2013

Conversation

Projects
None yet
4 participants
Owner

jmikola commented Apr 1, 2013

This includes commits from #203, rebased atop master.

Notable BC breaks:

  • Namespace change for all Type classes (Mapping/ is removed).
  • Type class constructor is private, so types must be fetched via Type::getType() (as is done in 43432d0).

/cc @l3pp4rd: Will this pose any problems for your extensions?

Contributor

l3pp4rd commented Apr 2, 2013

will check that, thanks for cc @jmikola

Contributor

l3pp4rd commented Apr 2, 2013

there is a place at least with translatable which checks the type. There are two ways, either check the odm version or use a new version in the master. When it is planed to be released?

Owner

jmikola commented Apr 3, 2013

BETA8 is the most recent tag, so I would tag BETA9 immediately after merging this. If you'd rather not depend on the versioning, you could add some code to prefer the Type class' new namespace or fall back to the original if that's not found.

@l3pp4rd l3pp4rd added a commit to Atlantic18/DoctrineExtensions that referenced this pull request Apr 3, 2013

@l3pp4rd l3pp4rd [translatable] support BC with changes in mongodb-odm c893252
Owner

jwage commented Apr 28, 2013

👍

@jmikola jmikola added a commit that referenced this pull request May 30, 2013

@jmikola jmikola Merge pull request #546 from doctrine/refactor-types
Refactor types to be consistent with other Doctrine adapters
2a2a5cf

@jmikola jmikola merged commit 2a2a5cf into master May 30, 2013

@jmikola jmikola deleted the refactor-types branch May 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment