Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update en/reference/query-builder.rst #143

Merged
merged 1 commit into from Jan 23, 2013

Conversation

Projects
None yet
4 participants
Contributor

relo-san commented Dec 7, 2012

Adding note for $append parameter of QueryBuilder::add() method.

Update en/reference/query-builder.rst
Adding note for $append parameter of QueryBuilder::add() method.
Contributor

relo-san commented Dec 7, 2012

I assumed that the documentation should reflect the actual behavior, but maybe I'm wrong and in this case it is better to fix the code according to the documentation.

Now $append param of QueryBuilder::add() has no effect for where and having parts.

In example:
$query->add('where', 'u.some = ?1');
$query->add('where', 'u.other = ?2', true);
will result in the loss of condition u.some = ?1

Owner

guilhermeblanco commented Dec 7, 2012

It sounds like a bug to me at initial glance. Please open a bug report for verification

Contributor

relo-san commented Dec 7, 2012

Ok. I'm posted bug report DDC-2191.

beberlei added a commit that referenced this pull request Jan 23, 2013

Merge pull request #143 from relo-san/patch-1
Update en/reference/query-builder.rst

@beberlei beberlei merged commit 8fcf2d4 into doctrine:master Jan 23, 2013

Owner

beberlei commented Jan 23, 2013

Its right, where() and having() use objects that need to be modified.

how to make complex orderby , like column="XXX" DESC with symfony 2.3.3 Thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment