You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Method setNamespace is called in Setup::createConfiguration, but at the moment there can be an instance of Doctrine\Common\Cache\Cache (when given in the 3rd parameter), which does not define this method. This method is defined in Doctrine\Common\Cache\CacheProvider from which are the defaults being instantiated in this method extended.
So there should be an condition or the 3rd parameter should declare a dependency on CacheProvider rather than just Cache interface. Or maybe the namespace should be set only if the Cache instance is not given by the 3rd parameter (as proposed in this PR now), assuming that when someone is giving a ready instance of Cache, it is configured properly.
If you want to take another approach, I can change this PR.
The text was updated successfully, but these errors were encountered:
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of VasekPurchart:
Url: #1071
Message:
Method
setNamespace
is called inSetup::createConfiguration
, but at the moment there can be an instance ofDoctrine\Common\Cache\Cache
(when given in the 3rd parameter), which does not define this method. This method is defined inDoctrine\Common\Cache\CacheProvider
from which are the defaults being instantiated in this method extended.So there should be an condition or the 3rd parameter should declare a dependency on
CacheProvider
rather than justCache
interface. Or maybe the namespace should be set only if the Cache instance is not given by the 3rd parameter (as proposed in this PR now), assuming that when someone is giving a ready instance of Cache, it is configured properly.If you want to take another approach, I can change this PR.
The text was updated successfully, but these errors were encountered: