Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-3582: Nested embeddables are instantiated with the wrong class #4403

Open
doctrinebot opened this issue Feb 22, 2015 · 6 comments
Open
Assignees
Labels

Comments

@doctrinebot
Copy link

Jira issue originally created by user jankramer:

Consider the example where an entity contains an embeddable, that itself contains 2 different embeddables. So Entity -> Embeddable 1 -> (Embeddable 2, Embeddable 3). In this case, Embeddable1 will be instantiated as an Embeddable2 for some reason.

Please see https://github.com/jankramer/doctrine2/commit/5e6b02a0fa9a1216b4e4d075061619288af74e7a for a test that demonstrates this and currently fails.

I looked at the code in the ReflectionEmbeddedProperty, and noticed that 'embeddedClass' was recently changed from 'class'. If I change it back, this test passes, but then the ReflectionEmbeddedPropertyTest fails on the scenario for abstract classes. @Ocramius, I saw you were the author on that change, could you please take a look? Thanks!

@doctrinebot
Copy link
Author

Comment created by jankramer:

Closing this as I can't seem to reproduce this issue anymore.

@doctrinebot
Copy link
Author

Comment created by jankramer:

Now able to reproduce this issue, updated the description.

@doctrinebot
Copy link
Author

Comment created by @Ocramius:

[~jankramer] please send a PR with that diff

@doctrinebot
Copy link
Author

Comment created by jankramer:

@Ocramius See #1311

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1311] was assigned:
#1311

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1311] was merged:
#1311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants