Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-4159: [GH-1579] Reduce code duplication in ProxyFactory::createInitializer #4912

Closed
doctrinebot opened this issue Dec 6, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@doctrinebot
Copy link

@doctrinebot doctrinebot commented Dec 6, 2015

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of aschempp:

Url: #1579

Message:

The only difference between the ~30 lines in the IF-statement is that the **wakup method is called on the proxy object. The "simplified" version adds the if-statement using an inherited flag in the closure.

@Ocramius Ocramius added this to the 2.6.0 milestone Dec 11, 2015
@Ocramius Ocramius assigned Ocramius and unassigned beberlei Dec 11, 2015
@Ocramius

This comment has been minimized.

Copy link
Member

@Ocramius Ocramius commented Dec 11, 2015

Fixed via #1579

@Ocramius Ocramius closed this Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.