Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop triggering static analysis workflows on tests #10136

Merged
merged 1 commit into from Oct 17, 2022

Conversation

greg0ire
Copy link
Member

In my opinion it is not great that we do not run static analysis tools on tests, but since we do not, let us stop triggering extra jobs for no reason.

@SenseException
Copy link
Member

I don't understand what's the reason for this PR.

@beberlei
Copy link
Member

👍 Static analysis on tests is really not necessary

In my opinion it is not great that we do not run static analysis tools on
tests, but since we do not, let us stop triggering extra jobs for no reason.
@greg0ire
Copy link
Member Author

I don't understand what's the reason for this PR.

@SenseException this should help:

paths:
- lib
- tests/Doctrine/StaticAnalysis

orm/psalm.xml

Lines 12 to 13 in f08b67f

<directory name="lib/Doctrine/ORM" />
<directory name="tests/Doctrine/StaticAnalysis" />

Right now, only lib and tests/Doctrine/StaticAnalysis (which I originally forgot about) are analysed by both tools.

@greg0ire greg0ire added the CI label Oct 17, 2022
@greg0ire
Copy link
Member Author

ping @SenseException @derrabus 🙂

@greg0ire greg0ire added this to the 2.13.4 milestone Oct 17, 2022
@greg0ire greg0ire merged commit 90bc6dc into doctrine:2.13.x Oct 17, 2022
4 checks passed
@greg0ire greg0ire deleted the trigger-sa-workflows-less branch October 17, 2022 20:45
@SenseException
Copy link
Member

I'm too much of a fan for SA for tests because it can improve strictness and might make tests fail where they should fail. Are we going to drop tests-directories in all repositories to be consistent?

@greg0ire
Copy link
Member Author

Are we going to drop tests-directories in all repositories to be consistent?

I have no such plan, and I think other repositories already have a good level of SA, so I'd say let's keep the ORM an exception to this rule for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants