Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust expectation #10239

Merged
merged 1 commit into from Nov 20, 2022
Merged

Adjust expectation #10239

merged 1 commit into from Nov 20, 2022

Conversation

greg0ire
Copy link
Member

RuntimePublicReflectionProperty has been deprecated in favor of RuntimeReflectionProperty in doctrine/persistence#307.

@greg0ire greg0ire force-pushed the adjust-expectations branch 2 times, most recently from 3a3c820 to edf1b7c Compare November 19, 2022 14:36
composer.json Outdated
@@ -32,7 +32,7 @@
"doctrine/inflector": "^1.4 || ^2.0",
"doctrine/instantiator": "^1.3",
"doctrine/lexer": "^1.2.3",
"doctrine/persistence": "^2.4 || ^3",
"doctrine/persistence": "^2.4 || ^3.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this 3.0 version skip at least happen in a minor release instead of a patch one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'll revert this, it's no longer necessary now that the test handles both cases.

RuntimePublicReflectionProperty has been deprecated in favor of
RuntimeReflectionProperty.

Let us use a more robust assertion.
@derrabus derrabus merged commit a5a6cc6 into doctrine:2.13.x Nov 20, 2022
34 checks passed
derrabus added a commit to derrabus/orm that referenced this pull request Nov 20, 2022
* 2.13.x:
  Remove fragile assertions (doctrine#10239)
derrabus added a commit to derrabus/orm that referenced this pull request Nov 20, 2022
* 2.14.x:
  Remove fragile assertions (doctrine#10239)
  update help for RunDqlCommand (doctrine#10233)
  Make the code easier to statically analyse
  Widen parameter type
  Document property as non-nullable
derrabus added a commit to derrabus/orm that referenced this pull request Nov 20, 2022
* 2.14.x:
  Remove fragile assertions (doctrine#10239)
  update help for RunDqlCommand (doctrine#10233)
  Make the code easier to statically analyse
  Widen parameter type
  Document property as non-nullable
derrabus added a commit to derrabus/orm that referenced this pull request Nov 20, 2022
* 2.13.x:
  Remove fragile assertions (doctrine#10239)
derrabus added a commit to derrabus/orm that referenced this pull request Nov 20, 2022
* 2.14.x:
  Remove fragile assertions (doctrine#10239)
  update help for RunDqlCommand (doctrine#10233)
  Make the code easier to statically analyse
  Widen parameter type
  Document property as non-nullable
derrabus added a commit to derrabus/orm that referenced this pull request Nov 20, 2022
* 2.14.x:
  Remove fragile assertions (doctrine#10239)
  update help for RunDqlCommand (doctrine#10233)
  Make the code easier to statically analyse
  Widen parameter type
  Document property as non-nullable
@greg0ire greg0ire deleted the adjust-expectations branch November 20, 2022 21:02
@derrabus derrabus added this to the 2.13.4 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants