Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some redundant clauses #1026

Merged
merged 1 commit into from May 2, 2014
Merged

Remove some redundant clauses #1026

merged 1 commit into from May 2, 2014

Conversation

flack
Copy link
Contributor

@flack flack commented May 2, 2014

The objectmanager insertion logic was identical in the if and else clauses, so I replaced both occurences with one directly after the else block closes. It is semantically identical but a little more readable, especially since the method has more than 250 lines (and a cyclomatic complexity of 100 or so :-)) as it is.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3114

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius Ocramius self-assigned this May 2, 2014
Ocramius added a commit that referenced this pull request May 2, 2014
Remove some redundant clauses
@Ocramius Ocramius merged commit 94837a0 into doctrine:master May 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants