Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrutinizer clear code #5911

Merged
merged 9 commits into from Jul 5, 2016

Conversation

@ReenExe
Copy link
Contributor

ReenExe commented Jul 2, 2016

only UnitOfWork

@@ -1155,9 +1155,9 @@ private function getCommitOrder(array $entityChangeSet = null)
}
$joinColumns = reset($assoc['joinColumns']);
$isNullable = isset($joinColumns['nullable']) ? $joinColumns['nullable'] : false;
$weight = (int)empty($joinColumns['nullable']);

This comment has been minimized.

Copy link
@Ocramius

Ocramius Jul 5, 2016

Member

Consider inlining this into $calc->addDependency(, since the variable isn't used anywhere else.

This comment has been minimized.

Copy link
@ReenExe

ReenExe Jul 5, 2016

Author Contributor

@Ocramius, ok (i think about code as comment)
Done, wait for build

@Ocramius

This comment has been minimized.

Copy link
Member

Ocramius commented Jul 5, 2016

@ReenExe thanks!

Note: please be more specific with commit messages in further PRs - the current commit messages don't really explain what/why something was done :-)

@Ocramius Ocramius added the Improvement label Jul 5, 2016
@Ocramius Ocramius added this to the 2.6.0 milestone Jul 5, 2016
@Ocramius Ocramius self-assigned this Jul 5, 2016
@Ocramius Ocramius merged commit 27e9b49 into doctrine:master Jul 5, 2016
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.