Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EntityManagerDecorator tests #6287

Merged
merged 1 commit into from Feb 13, 2017

Conversation

@lcobucci
Copy link
Member

lcobucci commented Feb 12, 2017

We were expecting a return value for all methods but on doctrine/common@6a56df9
we changed some methods to be void and of course that affected the
ORM.

We were expecting a return value for all methods but on doctrine/common@6a56df9
we changed some methods to be void and of course that affected the
ORM.
@lcobucci lcobucci added the Bug label Feb 12, 2017
@lcobucci lcobucci added this to the 2.6.0 milestone Feb 12, 2017
@lcobucci lcobucci self-assigned this Feb 12, 2017
@lcobucci lcobucci requested a review from Ocramius Feb 12, 2017
@Ocramius

This comment has been minimized.

Copy link
Member

Ocramius commented Feb 13, 2017

LGTM 👍

@Ocramius Ocramius merged commit e4704be into doctrine:master Feb 13, 2017
2 checks passed
2 checks passed
Scrutinizer 3 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.