New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require PHP 7.2, drop <7.2 in Composer & on Travis #6577

Merged
merged 1 commit into from Nov 30, 2017

Conversation

4 participants
@Majkl578
Copy link
Member

Majkl578 commented Jul 23, 2017

Targeting develop; closes #6529.

How should I fix Scrutinizer (probably no 7.2 yet)? Is it even a blocker for develop? Oh cool, Scrutinizer doesn't seem to bother with develop. ^^

@Ocramius

This comment has been minimized.

Copy link
Member

Ocramius commented Jul 24, 2017

We are all still on 7.1 with our dev envs though ;-)

@lcobucci lcobucci force-pushed the doctrine:develop branch from 10da164 to c192646 Jul 28, 2017

@Majkl578 Majkl578 force-pushed the Majkl578:dev/require-7.2 branch from d1ccd2b to 30616c4 Jul 29, 2017

@Majkl578 Majkl578 force-pushed the Majkl578:dev/require-7.2 branch from 30616c4 to bec4795 Aug 29, 2017

@Majkl578

This comment has been minimized.

Copy link
Member

Majkl578 commented Aug 29, 2017

RC1 coming out this week, when do you think you will feel ready @Ocramius @guilhermeblanco? 😋

@guilhermeblanco

This comment has been minimized.

Copy link
Member

guilhermeblanco commented Aug 30, 2017

@Majkl578 I mainly use homebrew for local development (specially for debug purposes) and would wait until xdebug gets compatible/built with PHP 7.2.

@guilhermeblanco guilhermeblanco added this to the 3.0 milestone Aug 30, 2017

@Majkl578

This comment has been minimized.

Copy link
Member

Majkl578 commented Aug 30, 2017

Damn, forgot about that poor thing... XDebug works when compiled from master (I have it locally on Linux), but there is no tagged version compatible with 7.2 yet. :/

@guilhermeblanco guilhermeblanco added this to Backlog in ORM.NEXT Sep 2, 2017

@Majkl578 Majkl578 force-pushed the Majkl578:dev/require-7.2 branch from bec4795 to d686308 Nov 30, 2017

@Majkl578

This comment has been minimized.

Copy link
Member

Majkl578 commented Nov 30, 2017

Ping, 7.2.0 is GA now.

@Ocramius Ocramius self-assigned this Nov 30, 2017

@Ocramius Ocramius merged commit 9f5fd37 into doctrine:develop Nov 30, 2017

0 of 2 checks passed

Scrutinizer Errored
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@Ocramius

This comment has been minimized.

Copy link
Member

Ocramius commented Nov 30, 2017

🚢

@lcobucci

This comment has been minimized.

Copy link
Member

lcobucci commented Nov 30, 2017

I mainly use homebrew for local development (specially for debug purposes) and would wait until xdebug gets compatible/built with PHP 7.2.

@Ocramius I thought we were going to wait for this ☝️ Xdebug 2.6 is not out yet...

@Ocramius

This comment has been minimized.

Copy link
Member

Ocramius commented Nov 30, 2017

@lcobucci no need for xdebug to run the basics - we really only need it for coverage, which isn't relevant atm

@lcobucci

This comment has been minimized.

Copy link
Member

lcobucci commented Nov 30, 2017

@Ocramius @guilhermeblanco requested to wait but yeah ¯_(ツ)_/¯

@Majkl578

This comment has been minimized.

Copy link
Member

Majkl578 commented Nov 30, 2017

You can always compile it from master, XDebug is not really good at frequent releases, pretty much like ORM. 😂
It's actually their recommendation to build from master only:

Although it is recommended to run the latest version from the master branch, older versions are available through tags.

@Majkl578 Majkl578 deleted the Majkl578:dev/require-7.2 branch Nov 30, 2017

@Majkl578

This comment has been minimized.

Copy link
Member

Majkl578 commented Dec 11, 2017

Looks like this got lost and is missing from develop after rebase. ping @guilhermeblanco

@Majkl578

This comment has been minimized.

Copy link
Member

Majkl578 commented Jan 1, 2018

Reapplied lost commit as d4ed772.

@guilhermeblanco guilhermeblanco moved this from Backlog to Closed in ORM.NEXT Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment