Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented "contains" operator for Criteria expressions #791

Merged
merged 1 commit into from Oct 11, 2013

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Sep 16, 2013

Criteria expressions support the contains operator, and it is implemented for the ArrayCollection. However, it wasn't implemented in the QueryExpressionVisitor, the ORM implementation.

This is the implementation and the test.

The only thing I'm wondering: is the % wildcard valid for all supported RDBMS for the LIKE operator? After a quick search, it seems like so, but you guys probably know for sure.

FYI it seems that someone created an issue for this, but it was closed: DDC-2394

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2682

We use Jira to track the state of pull requests and the versions they got
included in.

@mnapoli
Copy link
Contributor Author

mnapoli commented Oct 11, 2013

ping

This is a fairly simple fix, and annoying bug :)

guilhermeblanco added a commit that referenced this pull request Oct 11, 2013
Implemented "contains" operator for Criteria expressions
@guilhermeblanco guilhermeblanco merged commit be81b46 into doctrine:master Oct 11, 2013
@Thinkscape
Copy link

Thank you for that. I'm now patching all 2.4 instances with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants