Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of function in OrderBy #918

Closed
wants to merge 1 commit into from
Closed

Conversation

iamluc
Copy link

@iamluc iamluc commented Jan 24, 2014

This commit adds support for functions (like CONCAT()) in OrderBy.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2934

We use Jira to track the state of pull requests and the versions they got
included in.

@iamluc
Copy link
Author

iamluc commented Jan 24, 2014

Already debated in #288
But quoting wikipedia : "The sort criteria can be expressions, including – but not limited to – column names, user-defined functions, arithmetic operations, or CASE expressions".

I think the ORM component should not care about this and rely on the platform in the Dbal component.

@guilhermeblanco guilhermeblanco self-assigned this Apr 16, 2014
@guilhermeblanco
Copy link
Member

@iamluc I manually applied your changes as it was missing some pieces like docs and docblock and now this funcionality is available at 2.5 branch (currently dev-master) as of ceada41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants