Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing join-tables added in example #938

Merged
merged 2 commits into from Feb 6, 2014
Merged

Conversation

HermanPeeren
Copy link
Contributor

There are 2 many-to-may associations between the users and comments. Both use another join-table. The join-tables user_favorite_comments and user_read_comments must be specified. Otherwise the default "user_comment" is taken twice, resulting in an error.

See https://groups.google.com/forum/#!topic/doctrine-user/Kti36_n6490 and https://groups.google.com/forum/#!topic/doctrine-user/TYwafhgYiSU

There are 2 many-to-many associations between the users and comments. Both use another join-table. The join-tables user_favorite_comments and user_read_comments must be specified. Otherwise the default "user_comment" is taken twice. See https://groups.google.com/forum/#!topic/doctrine-user/Kti36_n6490 and https://groups.google.com/forum/#!topic/doctrine-user/TYwafhgYiSU
removed some spaces that had come into it while editing last commit
@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2961

We use Jira to track the state of pull requests and the versions they got
included in.

Ocramius added a commit that referenced this pull request Feb 6, 2014
Missing join-tables added in example
@Ocramius Ocramius merged commit 7ceb9b0 into doctrine:master Feb 6, 2014
@HermanPeeren
Copy link
Contributor Author

Thanks mate! That was fast! This was small, but hope to contribute more to Doctrine soon. Ciao, Herman

@Ocramius
Copy link
Member

Ocramius commented Feb 6, 2014

@HermanPeeren thank you for spotting the mistake! That was indeed an annoying one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants