Skip to content

[WIP] Add support for type parameters #20

Closed
wants to merge 3 commits into from

2 participants

@jakzal
jakzal commented Jan 24, 2012

This is work in progress initially discussed in #18.

Done so far:

  • Added support for type parameters (in Type classes)
  • Refactored DateTimeType to accept format option
  • Extracted common date/time code to parent DateTimeType class
  • All date/time types behave like before by default but accept format parameter which alters the bahvior

To be done:

  • Add type parameters to the metadata
  • Pass parameters to convertToPHPValue() and convertToXmlValue() methods in the XmlMarshaller
@richardfullmer
Doctrine member

I do plan to do some type refactoring in the near future on the master branch and add the following types:

  • array<T>
  • array<K, V>
  • ArrayCollection<T>
  • ArrayCollection<K, V>

to better flesh out some use cases I currently have. This obviously doesn't solve the format problems for DateTime, but I do think we should change the default DateTime format in the present Type to be ISO 8601

@jakzal jakzal closed this Jan 27, 2013
@jakzal jakzal deleted the jakzal:DateTypeRefactoring branch Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.