Skip to content

Removed parameter from ObjectManager::clear()#174

Merged
greg0ire merged 1 commit intodoctrine:3.0.xfrom
smilesrg:8460_deprecate_em_clear_with_entity_name_
Jun 16, 2021
Merged

Removed parameter from ObjectManager::clear()#174
greg0ire merged 1 commit intodoctrine:3.0.xfrom
smilesrg:8460_deprecate_em_clear_with_entity_name_

Conversation

@smilesrg
Copy link
Contributor

doctrine/orm#8460

Removed parameter from ObjectManager::clear().

For passing the tests successfully, this PR needs to be merged doctrine/common#928

@greg0ire
Copy link
Member

greg0ire commented Jun 5, 2021

For passing the tests successfully, this PR needs to be merged doctrine/common#928

That PR has been closed. What should happen to this one?

@alcaeus
Copy link
Member

alcaeus commented Jun 16, 2021

This is fine for 3.0. I don't think we need to worry about doctrine/common at all.

@greg0ire greg0ire force-pushed the 8460_deprecate_em_clear_with_entity_name_ branch from b57ca3a to e60a5ca Compare June 16, 2021 06:43
@greg0ire greg0ire force-pushed the 8460_deprecate_em_clear_with_entity_name_ branch from e60a5ca to 8b0e549 Compare June 16, 2021 06:51
@alcaeus alcaeus added this to the 3.0.0 milestone Jun 16, 2021
@greg0ire greg0ire merged commit bc6921b into doctrine:3.0.x Jun 16, 2021
@greg0ire
Copy link
Member

Thanks @smilesrg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants