Skip to content

Decouple RuntimePublicReflectionProperty::getValue() from Doctrine\Common\Proxy\Proxy#306

Merged
greg0ire merged 1 commit intodoctrine:3.1.xfrom
nicolas-grekas:no-proxy
Aug 20, 2022
Merged

Decouple RuntimePublicReflectionProperty::getValue() from Doctrine\Common\Proxy\Proxy#306
greg0ire merged 1 commit intodoctrine:3.1.xfrom
nicolas-grekas:no-proxy

Conversation

@nicolas-grekas
Copy link
Member

On the path to decoupling from doctrine/common
Somewhat related to #299

@greg0ire
Copy link
Member

Nice trick! I'd update the PR to remove now useless Phpstan ignore rules, but I'm on my phone.

Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite excited about rebasing #299 after this gets merged :) That circular dependency has been a pain.

Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@malarzm malarzm added this to the 3.1.0 milestone Aug 20, 2022
@greg0ire greg0ire merged commit f9007b4 into doctrine:3.1.x Aug 20, 2022
@greg0ire
Copy link
Member

Thanks @nicolas-grekas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants