Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed attribute names #23

Merged
merged 1 commit into from Mar 21, 2013

Conversation

Projects
None yet
2 participants
Contributor

dantleech commented Mar 20, 2013

These seem to be the correct XML attribute names, but I wonder if they should be camel cased like fieldName ?

Member

dbu commented Mar 21, 2013

judging from this document, the policy for xml is lowercase and connected by -. http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/xml-mapping.html

if there are some camel case things, this is an inconsistency that we should eliminate as soon as possible as once we are stable, it will be impossible to change anymore.

dbu added a commit that referenced this pull request Mar 21, 2013

@dbu dbu merged commit f73e81b into doctrine:master Mar 21, 2013

Member

dbu commented Mar 21, 2013

thanks a lot, this will save some people quite some hair they would otherwise pull when trying to figure this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment