Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move annotation definitions into PSR-0 compatible separate classes #410

Closed
dbu opened this issue Feb 2, 2014 · 1 comment
Closed

Move annotation definitions into PSR-0 compatible separate classes #410

dbu opened this issue Feb 2, 2014 · 1 comment
Labels
Easy Pick feature
Milestone
1.1

Comments

@dbu
Copy link
Member

dbu commented Feb 2, 2014

Move all classes defined in DoctrineAnnotations into separate files in that namespace and have DoctrineAnnotations.php require all those files for BC compatibility.

This will get us rid of the requirement to do AnnotationRegistry::registerFile(__DIR__.'/../vendor/doctrine/phpcr-odm/lib/Doctrine/ODM/PHPCR/Mapping/Annotations/DoctrineAnnotations.php'); in the bootstrapping.
@gnat42
Copy link
Contributor

gnat42 commented Feb 3, 2014

I have no idea how to add a PR to an existing issue... as such I've created a PR #412 for this.

@lsmith77 lsmith77 closed this as completed Feb 4, 2014
@inssein inssein mentioned this issue Jul 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Pick feature
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
3 participants
@dbu @lsmith77 @gnat42