Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

QueryBuilder clone should do a deep clone #413

Closed
dbu opened this Issue · 6 comments

3 participants

David Buchmann dantleech Lukas Kahwe Smith
David Buchmann
Collaborator
dbu commented

To make it possible to reuse a query builder, clone should recursively clone all parts of the querybuilder.

David Buchmann dbu referenced this issue in doctrine/DoctrinePHPCRBundle
Closed

QueryBuilder clone should do a deep clone #116

dantleech

Should this be in 1.1 -- why is cloning important? Do we risk introducing unexpected behavior or breaking things in the future by not having it in this release?

David Buchmann
Collaborator
dbu commented
David Buchmann
Collaborator

@lsmith77 btw, the phpcr-utils query builder does not implement clone either, should it?

Lukas Kahwe Smith
Owner

i think it makes sense to provide it for queries .. not sure if it makes sense to bother for the builder

David Buchmann dbu added the query label
David Buchmann
Collaborator

so should we close this issue?

Lukas Kahwe Smith
Owner

imho yes

David Buchmann dbu closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.