QueryBuilder clone should do a deep clone #413

Closed
dbu opened this Issue Feb 4, 2014 · 6 comments

3 participants

@dbu
Doctrine member
dbu commented Feb 4, 2014

To make it possible to reuse a query builder, clone should recursively clone all parts of the querybuilder.

@dbu dbu referenced this issue in doctrine/DoctrinePHPCRBundle Feb 4, 2014
Closed

QueryBuilder clone should do a deep clone #116

@dantleech

Should this be in 1.1 -- why is cloning important? Do we risk introducing unexpected behavior or breaking things in the future by not having it in this release?

@dbu
Doctrine member
@dbu
Doctrine member

@lsmith77 btw, the phpcr-utils query builder does not implement clone either, should it?

@lsmith77
Doctrine member

i think it makes sense to provide it for queries .. not sure if it makes sense to bother for the builder

@dbu dbu added the query label Feb 15, 2014
@dbu
Doctrine member

so should we close this issue?

@lsmith77
Doctrine member

imho yes

@dbu dbu closed this Mar 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment