Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodenames in Children collection with filter #447

Open
dbu opened this issue Mar 6, 2014 · 2 comments
Open

Nodenames in Children collection with filter #447

dbu opened this issue Mar 6, 2014 · 2 comments

Comments

@dbu
Copy link
Member

dbu commented Mar 6, 2014

in #446 i add validation on the Child mapping so that you can't misuse that field to persist a document that is not attached to that field.

we could do the same in the Children, check the name with the filter that is set on the mapping and refuse a name that does not match. could save quite some confusion when somebody is getting it wrong.

whats more, related to #358 we could integrate with autoname strategy by passing along a name hint that will match the filter. so for example if my filter is block* the namehint would be "block" so that i can actually use children and autoname documents together. this is a special case anyways, so i guess checking what type of id generator this is and call a specific method should be ok, do you agree? at the same time i would love to fix #358 and define precedence if both the document and the children mapping indicate a name hint. i think the children collection hint should win in that case, over the hint on the id. (its more sane to have hints from the children mapping than fixed on a document class anyways i think)

@dbu dbu added this to the 1.2 milestone Mar 7, 2014
@dbu
Copy link
Member Author

dbu commented Mar 7, 2014

okay, this really aught to be 1.2, we have to stop at some point. lets first get 1.1 out before further discussing this one.

@dbu dbu removed this from the 1.2 milestone Sep 29, 2014
@dbu
Copy link
Member Author

dbu commented Sep 29, 2014

removed the milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant