translate parent and nodename assignments to move operations #141

Merged
merged 2 commits into from Jun 5, 2012

Conversation

Projects
None yet
3 participants
@dbu
Member

dbu commented Jun 4, 2012

move documents by assigning different nodename and / or different parent.

is this fully correct? was almost too easy...

@dbu dbu referenced this pull request Jun 4, 2012

Merged

Move update fields #142

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Jun 5, 2012

Member

looks good to me, but can you check the tests in HierarchyTest?

Member

lsmith77 commented Jun 5, 2012

looks good to me, but can you check the tests in HierarchyTest?

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Jun 5, 2012

Member

specifically the "testNodenameChangeException", "testParentChangeException" and "testIdChangeException"

Member

lsmith77 commented Jun 5, 2012

specifically the "testNodenameChangeException", "testParentChangeException" and "testIdChangeException"

@lsmith77 lsmith77 closed this Jun 5, 2012

@lsmith77 lsmith77 reopened this Jun 5, 2012

dbu added a commit that referenced this pull request Jun 5, 2012

Merge pull request #141 from doctrine/assignment_move
translate parent and nodename assignments to move operations

@dbu dbu merged commit f96f6c9 into master Jun 5, 2012

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Jun 6, 2012

This pull request passes (merged 66ba5cc into 611f90f).

This pull request passes (merged 66ba5cc into 611f90f).

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Jun 6, 2012

This pull request passes (merged 66ba5cc into 611f90f).

This pull request passes (merged 66ba5cc into 611f90f).

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Jun 6, 2012

This pull request passes (merged 19800d5 into 611f90f).

This pull request passes (merged 19800d5 into 611f90f).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment