Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

added support for hashmaps (PHPCR-56) #180

Merged
merged 3 commits into from Oct 8, 2012

Conversation

Projects
None yet
2 participants
Member

lsmith77 commented Oct 4, 2012

also added finalization step to the class metadata validation (partially covers PHPCR-60)

see http://doctrine-project.org/jira/browse/PHPCR-56 and http://doctrine-project.org/jira/browse/PHPCR-60

Member

dbu commented Oct 4, 2012

this is really cool stuff. guess once this landed, we can simplify quite a few documents. one question: assoc always needs a name parameter, right? i can't just say assoc and doctrine would magically append something to value property name to be used to store the keys? we could do something like phpcr:keys_...

Member

lsmith77 commented Oct 4, 2012

i pondered also allowing a boolean true, which would then take the given property name and append "Keys", but figured it wasnt really worth the trouble, because i think we definitely also want to make it possible to specify the full property name. but it would not be too hard to add.

i actually tried to simplify the Route document and its quite a nightmare since the properties are private .. also we currently always set a Collection instance which doesnt work for all array functions. was pondering if we need another option to specify that we always want an array back for the multivalue property rather than a Collection.

added support for hashmaps (PHPCR-56), added finalization step to the…
… class metadata validation (partially covers PHPCR-60)

@lsmith77 lsmith77 referenced this pull request in symfony-cmf/routing-bundle Oct 5, 2012

Merged

use the hashmap support in PHPCR ODM #20

dbu added a commit that referenced this pull request Oct 8, 2012

Merge pull request #180 from doctrine/hashmaps
added support for hashmaps (PHPCR-56)

@dbu dbu merged commit 96ce1ba into master Oct 8, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment