cleanup image and file documents #265

Merged
merged 1 commit into from Mar 13, 2013

Conversation

Projects
None yet
2 participants
@dbu
Member

dbu commented Mar 12, 2013

clean up the documents so we can better use them

+ *
+ * @return Resource
+ */
+ public function getContent()

This comment has been minimized.

@dbu

dbu Mar 12, 2013

Member

@uwej711 not sure why we made this method private originally, but to access mime type or last modified date, its quite handy to access the Resource document.

@dbu

dbu Mar 12, 2013

Member

@uwej711 not sure why we made this method private originally, but to access mime type or last modified date, its quite handy to access the Resource document.

This comment has been minimized.

@uwej711

uwej711 Mar 12, 2013

Contributor

No reason to not access the resource. It was probably just not needed at that moment

@uwej711

uwej711 Mar 12, 2013

Contributor

No reason to not access the resource. It was probably just not needed at that moment

@dbu

This comment has been minimized.

Show comment
Hide comment
@dbu

dbu Mar 12, 2013

Member

it seems we only used the Image document as a child until now, there was not even a setter for the path / id.

Member

dbu commented Mar 12, 2013

it seems we only used the Image document as a child until now, there was not even a setter for the path / id.

dbu added a commit that referenced this pull request Mar 13, 2013

@dbu dbu merged commit 77de4b1 into master Mar 13, 2013

1 check passed

default The Travis build passed
Details

@dbu dbu deleted the cleanup-image-file-documents branch Mar 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment