Verify that uuid is only mapped on referenceable documents #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function validateReferenceable() | ||
| { | ||
| if ($this->uuidFieldName && !$this->referenceable && !'full' === $this->versionable) { |
There was a problem hiding this comment.
simple versionable does not imply referenceable. not sure if this check is too restrictive as custom mixins could extend referenceable as well - but worst case you just need to explicitly set referenceable to true in that case.
dbu
force-pushed
the
validate-uuid-referenceable
branch
from
b9443a2
to
7002cdc
Compare
|
simplified the comparison statement. |
lsmith77
added a commit
that referenced
this pull request
May 1, 2015
Verify that uuid is only mapped on referenceable documents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jackalope started to verify that the uuid is not set on a non-referenceable node, leading to confusion when people map the uuid but do not make the document referenceable.