Add missing comparisons. #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrine#45 added a missing test for a fix, but only added a comparison for compression, the missing comparisons in the other files will cause newly added comparisons to fail, as they will be compared to the wrong SQL.
|
Nice catch! I added a commit that will make sure I notice my mistake next time it happens. |
greg0ire
approved these changes
Mar 25, 2021
|
Thanks @ndm2 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45 added a missing test for a fix, but only added a comparison for
compression, the missing comparisons in the other files will cause newly
added comparisons to fail, as they will be compared to the wrong SQL.